bootctrl: fall back to active slot if current slot not found in cmdline #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While postmarketOS makes use of a kernel cmdline argument, this isn't the case for all distros. Furthermore, this argument isn't present in those added automatically by the Android bootloader. In order to still be able to use `qbootctl` on other distros, this change ensures we use the currently active slot as the current slot when the cmdline argument is missing. This ensure `qbootctl -m` picks up the correct slot more often than not, instead of always defaulting to `_a`.
|
Sorry i totally missed this PR! Not sure how motivated you are still with this, the diff needs fixing (is it necessary to move the function?) and I think it would make sense to adjust the function name to reflect the fallback behaviour. I can also make these changes while merging given the timespan... |
Well it has to know about
Sure, do you have something specific in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While postmarketOS makes use of a kernel cmdline argument, this isn't the case for all distros. Furthermore, this argument isn't present in those added automatically by the Android bootloader.
In order to still be able to use
qbootctlon other distros, this change ensures we use the currently active slot as the current slot when the cmdline argument is missing. This ensureqbootctl -mpicks up the correct slot more often than not, instead of always defaulting to_a.